search

Lachee / discord-rpc-csharp

C# custom implementation for Discord Rich Presence. Not deprecated and still available!
MIT License
560 stars 93 forks source link

Image asset keys can be way longer than 32 #171

Closed maximmax42 closed 1 year ago

maximmax42 commented 2 years ago

Currently, trying to set a key that's longer than 32 symbols will result in StringOutOfRangeException being thrown, but apparently you can name your assets any name that's up to 999 symbols long. Here's the proof: https://discordapp.com/api/oauth2/applications/896771305108553788/assets.

Desktop (please complete the following information):

Lachee commented 2 years ago

Did PR #170 not fix this? Or has the automated builds broken and didnt publish to nuget?

maximmax42 commented 2 years ago

Latest nuget version is 175 from January 2021, so I guess autobuilds broke.

maximmax42 commented 2 years ago

Also, #170 only bumps up the max length to 256, which surely will be enough for pretty much everyone, but the true max length seems to be 999.

Lachee commented 2 years ago

Also, #170 only bumps up the max length to 256, which surely will be enough for pretty much everyone, but the true max length seems to be 999.

What discord lets you set via their web api maybe not the same as what they let you set in the RPC API unfortunately . I'll check the nuget and builds when i get some time this week. For now if you need a increased 256byte i recommend building yourself using the guide or waiting for the nuget release :)

Almighty-Shogun commented 2 years ago

Added to my "Fix list" for PR https://github.com/Lachee/discord-rpc-csharp/issues/176

Edit: Never mind, didn't see it was already merged... 🤦‍♂️