search

Lachee / discord-rpc-csharp

C# custom implementation for Discord Rich Presence. Not deprecated and still available!
MIT License
560 stars 93 forks source link

Nuget package is outdated #178

Closed Smaltin closed 1 year ago

Smaltin commented 2 years ago

Describe the bug The nuget package is outdated and is running the January 2021 version of the code

Expected behavior The package should be a more recent version involving the new URL keying for example

Additional context I believe it has to do with the nuget branch on Github being outdated, but I could be wrong.

Lachee commented 2 years ago

Yup, this is a known issue. The CI has failed to build and publish the last few nugget packages. I am waiting for Lachee/discord-rpc-unity#5 before I setup the CI and fix the nuget package.

leaving this issue open as a reminder

Almighty-Shogun commented 2 years ago

I can try to fix https://github.com/Lachee/discord-rpc-unity/issues/5 with my upcoming PR https://github.com/Lachee/discord-rpc-csharp/pull/177 but I can't guarantee anything for 100% sure since I have no acknowledgement and/or idea how unity exactly works

sll552 commented 2 years ago

Any Progress on this? with the latest nuget package external URLs dont seem to work.

Smaltin commented 2 years ago

@sll552 I went ahead and ended up using a local copy which I compiled (since I didn't expect any immediate updates). If you wish to start using the library now, you can use my compiled copy. You can follow progress at https://github.com/Lachee/discord-rpc-unity/issues/5 (which none has been made any time recently so I suppose that answers your question). The nuget package is outdated and will remain that way until 117 is resolved

I am waiting for https://github.com/Lachee/discord-rpc-unity/issues/5 before I setup the CI and fix the nuget package.

sll552 commented 2 years ago

Thanks, I guess if needed I would compile it myself. I don't really understand why a unity UI bug is preventing a release of the nuget package, maybe it would be possible to split the unity part in a separate repo which uses the nuget from this (just thinking loud, I don't actually know how unity integration works)? Also the mentioned rewrite/cleanup of @Almighty-Shogun is closed without comment. So whats the status of all of this? @Lachee

Lachee commented 1 year ago

nuget packages are part of gh actions now and wont be out of date anymore