search

Lachee / discord-rpc-csharp

C# custom implementation for Discord Rich Presence. Not deprecated and still available!
MIT License
561 stars 93 forks source link

Added Authorize Command. #247

Open skaughtx0r opened 3 months ago

skaughtx0r commented 3 months ago

This PR adds support for the Authorize command. I needed to be able to request additional scopes. This allows me to have the authorization prompt show up in the discord client app.

Lachee commented 3 months ago

Thank you for your contribution ❤ I am current unwell at the moment but will try to get to review your PR soon :)

Lachee commented 3 months ago

Looking great so far, just that minor tweak and it should be good to PR. Would you be able to provide some additional information on what you can do once you have the authorized code?

skaughtx0r commented 3 months ago

I'm using the authcode returned by the Authorize command to Authenticate with the REST API. From there I'm hitting the https://discordapp.com/api/users/@me/guilds/{GuildID}/member for my game's discord server to see if the user has a role assigned to give them access to extra stuff in the game.

I'm not sure how to fix the issues in the static analysis. My implementation is identical to the code you already had in there for other commands, they seem like false positives.

Lachee commented 2 months ago

I'm using the authcode returned by the Authorize command to Authenticate with the REST API. From there I'm hitting the https://discordapp.com/api/users/@me/guilds/{GuildID}/member for my game's discord server to see if the user has a role assigned to give them access to extra stuff in the game.

I'm not sure how to fix the issues in the static analysis. My implementation is identical to the code you already had in there for other commands, they seem like false positives.

Dont worry about the static code analysis, that is just a general thumb to ensure quality and not strict. I just need the review i posted to be resolved before I accept this PR :)

skaughtx0r commented 2 months ago

Oh weird, I don't see any reviews:

image