Lachee / discord-rpc-unity

C# custom implementation for Discord Rich Presence. Unity package to easy add to your own games.
MIT License
43 stars 2 forks source link

[BUG] OnJoinRequested is Broken in Unity Package #2

Open ryanhlewis opened 2 years ago

ryanhlewis commented 2 years ago

Describe the bug The OnJoinRequested callback is completely broken, no matter the amount of times I call "invoke", subscribe to the event, or elsewise. In fact, it's subscribed to in the main DiscordManager.cs file, with this line of code:

        client.OnJoinRequested += (s, args) => Debug.Log("[DRP] Join Requested");

Yet, that Debug is never called. No matter how many times I click "Request to Join" from a Discord client on the same computer or another, with multiple different accounts. However, the Join callback works perfectly, along with the Join subscribe, so I assume this part of the library is somehow just out-of-date or I'm using it wrong, but I've poured through the "Discord Game Invite Example" Unity scene, which seems to be broken as well.

To Reproduce Steps to reproduce the behavior:

  1. Set up a simple Discord Manager with a Party
  2. Try joining and requesting to join
  3. Notice in Debug.Log that the only event ever registered by the Logger is the Join Event

Expected behavior I expect that callback, clearly defined in the CS file, to actually callback. I expect, too, to see an event that pops up claiming that a Join Request event was received by the Logger, just like it pops up claiming the Join event was received.

Desktop (please complete the following information):

Logs

It's the lack of logs that's bothering me. I have the system perfectly working with Join events and Join subscriptions. The JoinRequest event just seems to not work.
Lachee commented 2 years ago

Yeah, you can thank Discord for this.

Pretty sure the OnJoinRequested is actually removed from Discord now, as they decided to make that notification in the Discord client instead. It use to work, and it use to be awesome and super swish :c

I'll double check this when I have the time.