search

Lachei / VulkanPBRT

Vulkan physically based raytracer including denoising
MIT License
28 stars 11 forks source link

Transmissives #31

Closed Lachei closed 2 years ago

Lachei commented 2 years ago

Adds transmissive materials for rendering. Current implementation supports rough transmission, meaning that for rough transmissive materials the ray is scattered instead of perfectly transmitted into the medium. Implementation does not keep track of current density of the object but assumes to always have a air/object intersection and uses a given ior number for altering the transmitted ray. This is done, as for obj scenes only the ior is given and no optical density. For the future to get more towards physically based tracing this should be converted to optical density and then being kept track of in the ray tracing.

Further this PR solves an error that occured on my system with newer assimp when trying to parse material color. This bugfix is done by exchanging the read method to the array read version in vsgXchange::assimp implementation. This version is the more stable one and should work bugfree for all versions of assimp.

For an example refractive scene see https://casual-effects.com/data/ the Cornell box set with a cornell box with a glass ball.

sven-luepke commented 2 years ago

@Lachei I created a small PR (#34) into this branch that incorporates my comments.

Lachei commented 2 years ago

Your change requests are all good. Will merge your updated branch when decided over naming convention.

Lachei commented 2 years ago

Was merged in #34 . Closing this as all changes are already in master.

sven-luepke commented 2 years ago

Was merged in #34 . Closing this as all changes are already in master.

@Lachei How are the changes from this PR already on master? From what I can see, the last commit to master has been 28 days ago.

Lachei commented 2 years ago

Your are of course right. I somehow thought merging #34 would be automatically merged into master...