Lachim / redis

Automatically exported from code.google.com/p/redis
2 stars 0 forks source link

Redis 2.0.2 fails with unexpected end of line using both Make & Gmake #343

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. gzip -dc redis-2.0.2.tar.gz | tar -xvf - ; cd redis-2.0.2
2. make

What is the expected output? What do you see instead?
 The process fails with the following error:
 "make: Fatal error in reader: Makefile, line 6: Unexpected end of line seen"

What version of the product are you using? On what operating system?
  Redis 2.0.2, Solaris SunOS 5.10 Generic_141445-09 i86pc i386 i86pc

Please provide any additional information below.
The same distribution works on Ubuntu but not on Solaris. I tried both Solaris 
Make and GNU Make but to no avail.
If the make file is not properly formatted I would expect both Ubuntu and 
Solaris to fail. I have also searched for issues and no one appears to have the 
same problem.

Original issue reported on code.google.com by peter.wa...@gmail.com on 12 Oct 2010 at 10:47

GoogleCodeExporter commented 8 years ago
To start: I don't use Solaris anywhere, nor am I anywhere experienced using it. 
However, I've managed to get a Solaris 10 VM up and running with development 
tools installed using http://www.opencsw.org/ . Then, when I issue "CC=gcc 
gmake", Redis compiles as it should (although with some compiler warnings).

My guess is that the tooling that comes with Solaris out of the box is not 
compatible with the make we use (GNU make). I would recommend using GNU make 
instead of the bundled one. Could you verify that this works for you?

Original comment by pcnoordh...@gmail.com on 12 Oct 2010 at 2:13

GoogleCodeExporter commented 8 years ago
Thanks for the quick response - Interesting i have been hearing about this 
pkg-get etc for Solaris. Can you tell me which specific development packages I 
require. I assume I will need GNU C++ and GMake but is their any other packages 
that I will need.

Packages:
gcc2 2.95.3,REV=2005.01.04
gmake 3.82,REV=2010.07.28

And of course I will happy to verify the results with you

Many thanks in advance!!

Original comment by peter.wa...@gmail.com on 14 Oct 2010 at 9:02

GoogleCodeExporter commented 8 years ago
Redis' Makefile containes GNU extensions such as:

  ifeq/else/endif or the operator ?=

It's normal that it doesn't work with PMake or BSD Make, but it should work 
with GNU Make. What kind of error does GNU Make produce?

Original comment by henrywho...@gmail.com on 25 Oct 2010 at 10:09