search

LacledesLAN / gamesvr

For Building Out LL Game Servers
MIT License
2 stars 0 forks source link

Build Errors Not Causing Script to Crash #1

Open dudleycodes opened 1 year ago

dudleycodes commented 1 year ago

We use these scripts to build docker images of the large gamer servers (those we can't build via GitHub actions).

We run these scripts on a cron job, and sometimes manually. It'll pull down repos as needed, and run build scripts from them as needed. So, this issues will affect all of these "child" build scripts as well.

Last night Valve updated CSGO. The build script was able to build gamesvr-csgo, gamesvr-csgo:base, and gamesvr-csgo:base-overtime. It failed building gamesvr-csgo:get5 due to an incompatibility issues w/ sourcemod and the latest version of CSGO. But, because the script kept chugging along we assumed everything was good.

These scripts (and the child scripts hosted in other repos), need to be updated, so that if there's a problem it stops dead in its tracks - and exits with a non-zero exit code.

dudleycodes commented 1 year ago

Tagging @cschellenbach for awareness.