search

LacunaSpace / basicmac

BasicMAC LoRaWAN stack that supports (but is not limited to) Arduino
Other
75 stars 18 forks source link

Missing a comma! #2

Closed ricaun closed 4 years ago

ricaun commented 4 years ago

Missing a comma! https://github.com/LacunaSpace/basicmac/blob/69e55e953b652ef26e52819ab77559e4a81baf70/lmic/lmic.c#L1295

matthijskooijman commented 4 years ago

Thanks for your pull request!

I've been fixing more stuff and doing some significant git history cleanups of the code, so I included this fix in the original that introduced the breakage. I pushed that to master, which I am intending to keep stable (i.e. without force pushes) from now on.

This fix should be present in master, so I'm closing this PR :-)

ricaun commented 4 years ago

Hello,

The last time I compiled your code in the Arduino library. https://github.com/ricaun/arduino-BasicMAC

The sx127x works ok but the sx126x I have some problem with the Dio3. My board does not have the DIO3 to drive connected to the crystal, and the code forces to use dio3 on SetDIO3AsTcxoCtrl.

I was trying to use US915 but the code has some bug on a REG_FIX, the join does not work very well.

I noticed the original code has updated to version a final release 2.2 https://github.com/lorabasics/basicmac

And a lot of the code change, like the nextJoinState has some update and the SetDIO3AsTcxoCtrldoes not exist anymore.

See yaa.

matthijskooijman commented 4 years ago

I moved your comment to a new issue, I'll reply there :-)