search

Ladsgroup / Vandalism-dashboard

Vandalism dashboard for Wikidata
GNU General Public License v3.0
8 stars 3 forks source link

Description always enabled #2

Closed lucaswerkmeister closed 6 years ago

lucaswerkmeister commented 6 years ago

As reported by Magnus on the mailing list – “changes in descriptions” is always enabled for some reason. Apparently, the code expects description=off in the query string when that checkbox is off (whereas for other checkboxes is only checks if they’re present or not), but I don’t understand why the browser would send that.

magnusmanske commented 6 years ago

Why would you expect it to be "off"? It's either undefined (not checked, thus not added to the request) or set to some value (probably true) here.