search

Ladvace / astro-bento-portfolio

Astro-bento-portfolio is a minimal bento-like (almost) single page portfolio website made in Astro
https://sparkly-speculoos-0c9197.netlify.app/
MIT License
176 stars 63 forks source link

Fix HTML structure in welcome/about me section #24

Closed colemilne54 closed 1 month ago

netlify[bot] commented 1 month ago

Deploy Preview for sparkly-speculoos-0c9197 ready!

Name Link
Latest commit 9343087a460d09f921a934f4a1c869280a5998a6
Latest deploy log https://app.netlify.com/sites/sparkly-speculoos-0c9197/deploys/669963aa68b5d90008f44adb
Deploy Preview https://deploy-preview-24--sparkly-speculoos-0c9197.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Ladvace commented 1 month ago

is there any reason for this?

colemilne54 commented 1 month ago

is there any reason for this?

Yes. WebStorm originally caught the issue and marked it as and error which brought it to my attention. According to the HTML specification section 4.4.1,

List elements (in particular, ol and ul elements) cannot be children of p elements.

Ladvace commented 1 month ago

is there any reason for this?

Yes. WebStorm originally caught the issue and marked it as and error which brought it to my attention. According to the HTML specification section 4.4.1,

List elements (in particular, ol and ul elements) cannot be children of p elements.

you are right, I didn't noticed it