App crashes if incorrect secret is entered

[tachille4]

General information App version: 0.7.0 App source: built from sources Android Version: Android 9 Custom ROM: emulator Same crash on actual devices with app 0.7.0 and 0.6.3.1 from F-Droid.

Expected result

What is expected? An error message is displayed.

What does happen instead? App crashes.

Logcat org.shadowice.flocke.andotp.dev E/AndroidRuntime: FATAL EXCEPTION: main Process: org.shadowice.flocke.andotp.dev, PID: 3414 java.lang.IllegalArgumentException: Last encoded character (before the paddings if any) is a valid base 32 alphabet but not a possible value. Expected the discarded bits to be zero. at org.apache.commons.codec.binary.Base32.validateCharacter(Base32.java:577) at org.apache.commons.codec.binary.Base32.decode(Base32.java:404) at org.apache.commons.codec.binary.BaseNCodec.decode(BaseNCodec.java:482) at org.apache.commons.codec.binary.BaseNCodec.decode(BaseNCodec.java:465) at org.shadowice.flocke.andotp.Database.Entry.(Entry.java:90) at org.shadowice.flocke.andotp.Dialogs.ManualEntryDialog$7.onClick(ManualEntryDialog.java:210) at com.android.internal.app.AlertController$ButtonHandler.handleMessage(AlertController.java:172) at android.os.Handler.dispatchMessage(Handler.java:106) at android.os.Looper.loop(Looper.java:193) at android.app.ActivityThread.main(ActivityThread.java:6669) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)

Steps to reproduce

1. Open entry creation dialog ("+" -> Enter details).
2. Enter "test" in the "Secret" field (and fill other required fields).

[terrys-probot[bot]]

Hello! LadyBug was able to find and rank files that may contain the bug mentioned in this issue.

File ranking in order of most likely to contain the bug to least likely:

Rank	File Path	Score
1	repos\LadyBugML\ladybug-data-android\app\src\release\java\io\github\zwieback\familyfinance\app\FamilyFinanceApplication.java	0.5312110185623169
2	repos\LadyBugML\ladybug-data-android\app\src\main\java\io\github\zwieback\familyfinance\business\backup\activity\BackupActivity.java	0.5199213624000549
3	repos\LadyBugML\ladybug-data-android\app\src\main\java\io\github\zwieback\familyfinance\core\activity\DataActivityWrapper.java	0.47901812195777893
4	repos\LadyBugML\ladybug-data-android\app\src\main\java\io\github\zwieback\familyfinance\business\dashboard\activity\DashboardActivity.java	0.47752171754837036
5	repos\LadyBugML\ladybug-data-android\app\src\main\java\io\github\zwieback\familyfinance\core\activity\ActivityWrapper.java	0.47473806142807007
6	repos\LadyBugML\ladybug-data-android\app\src\main\java\io\github\zwieback\familyfinance\core\storage\helper\InternalStorageHelper.java	0.47458913922309875
7	repos\LadyBugML\ladybug-data-android\app\src\main\java\io\github\zwieback\familyfinance\business\chart\dialog\HorizontalBarChartDisplayDialog.java	0.472944974899292
8	repos\LadyBugML\ladybug-data-android\app\src\main\java\io\github\zwieback\familyfinance\core\dialog\EntityFilterDialog.java	0.47126179933547974
9	repos\LadyBugML\ladybug-data-android\app\src\main\java\io\github\zwieback\familyfinance\business\preference\fragment\SettingsFragment.java	0.46684738993644714
10	repos\LadyBugML\ladybug-data-android\app\src\main\java\io\github\zwieback\familyfinance\core\activity\EntityActivity.java	0.4621865451335907

Please take the time read through each of these files.
If you have any problems with this response, or if you think an error occurred, please take the time to create an issue here: ladybug issues.
Happy coding!

[terrys-probot[bot]]

Thank you for opening this issue!

No preprocessed bug report was returned.

I did not find any images in the issue description.