search

LadyDefile / Wordsmith-DalamudPlugin

Wordsmith is a Dalamud Plugin aiming to make roleplay easier, more convenient, and harder to accidentally "wrong chat" your post.
7 stars 3 forks source link

Using a custom marker prints out code #37

Closed Dark-Cr0w closed 1 year ago

Dark-Cr0w commented 1 year ago

Hi there! Firstly wanted to say thank you for adding this feature in but I found a bug when i tried to use it at first :c

What I typed: image What it prints into the chat: [ not the :') ] image Current marks & tags options: image

I also tested with other markers- same thing just in the place where I set it for.

LadyDefile commented 1 year ago

Well damn. That is definitely not how that is supposed to work, lol. It seems I accidentally used a 'ToString()' call somewhere. I'll take a look at this and should have it patched up in the next couple hours. Just about to have my coffee.

LadyDefile commented 1 year ago

Seems I have another thing to add to my QA checklist.

LadyDefile commented 1 year ago

I found the problem and I was correct. Where I gather together the markers to be copied to clipboard I apparently had it converting the object via ToString() which was definitely wrong, lol. It's fixed and I'll send this update to Dalamud as soon as I run my QA list over it (including the new check to ensure everything copies properly, lol.)

LadyDefile commented 1 year ago

https://github.com/goatcorp/DalamudPluginsD17/pull/922

A fix is on the way! Once the Dalamud team gets around to approving this update this should be fixed along with several other bugs I managed to find today. The patch notes for the coming update are in the link I provided.