search

LadybirdBrowser / ancient-history

The Ladybird web browser
BSD 2-Clause "Simplified" License
1.62k stars 107 forks source link

Select location editor text on focus #112

Closed ghost closed 1 year ago

ghost commented 1 year ago

This PR lets us match the behavior of other browsers when clicking to focus the location editor.

ghost commented 1 year ago

I see the problem: when we create a new tab, we forcely load a "about:blank" page, to initialize the JS debugger view, which messes up you idea. This PR is just not working.

I have an implementation which works as you intend - I did hook into QTabWidget::currentChanged which means modification inside the browser window only (..and exposing some internals from Tab as by now they are internal/private members).

Ok, closing this PR and will wait for a more sensible solution to be implemented.