search

LadybirdBrowser / ancient-history

The Ladybird web browser
BSD 2-Clause "Simplified" License
1.62k stars 102 forks source link

Add support for Google Search in Address Bar #20

Closed shanmukhateja closed 2 years ago

shanmukhateja commented 2 years ago

This commit adds support for to search for anything within the address bar using Google Search just like a web browser should.

I've also added placeholder text to QLineEdit to indicate this to user.

Note

I went with Google as the browser was showing search results. This wasn't possible with Bing or with DuckDuckGo.

ghost commented 2 years ago

This should ultimately be a setting. And not hard-coded

shanmukhateja commented 2 years ago

Hello,

I agree however neither DuckDuckGo nor Bing can produce search results right now.

It's my first contribution to a CPP project. I have added FIXME for this in the code.

rwinkhart commented 2 years ago

Brave search also shows results!

awesomekling commented 2 years ago

Hello!

Directing traffic to random search engines is not a goal for this prototype. Perhaps one day we can do something like the ? queries in the SerenityOS Browser. But for now, please treat ladybird as a debugging tool for LibWeb. :)