LadybirdBrowser / ancient-history

The Ladybird web browser
BSD 2-Clause "Simplified" License
1.62k stars 102 forks source link

Meta: Add basic GitHub Actions workflow for ubuntu/macOS builds #65

Closed ADKaster closed 2 years ago

ADKaster commented 2 years ago

Let's verify that things at least build on pushes to master, and in PRs.

A few succesful CI runs from my fork showing the ccache working:

No ccache: https://github.com/ADKaster/ladybird/actions/runs/3075281272

Yes ccache: https://github.com/ADKaster/ladybird/actions/runs/3075390659

Creating UCD/CLDR/TZDB caches: https://github.com/ADKaster/ladybird/actions/runs/3078277536/jobs/4973731841

Full UCD/CLDR/TZDB caches: https://github.com/ADKaster/ladybird/actions/runs/3078478190

trflynn89 commented 2 years ago

You might want to add the UCD/CLDR/TZDB caches as well so we aren't hitting their servers as much. At least the UCD, since they host that on a server that isn't behind a CDN.

themisir commented 2 years ago

What about publishing build artifacts?

https://github.com/actions/upload-artifact

ADKaster commented 2 years ago

Publishing build artifacts is a non-goal. It's very easy to build the project.

themisir commented 2 years ago

Publishing build artifacts is a non-goal. It's very easy to build the project.

Makes sense, thanks