search

LadybirdBrowser / ancient-history

The Ladybird web browser
BSD 2-Clause "Simplified" License
1.62k stars 107 forks source link

Implement translations #71

Closed AaronDewes closed 1 year ago

AaronDewes commented 1 year ago

This adds translations to Ladybird. I initially translated it into German, but other languages can easily be added. I'm not actually sure if an English translation file is needed, but it could be helpful if you want to use translation tools like weblate.

Ideally, ninja -C Build ladybird_lupdate should be run after every change (maybe as a pre-commit hook?) because the .ts files in QT reference line numbers of the source files. But the lines numbers are only used to help translation and not required for any functionality.

Translations are currently embedded into the binary, but could also be moved into separate files (Embedding seemed easier to me).

awesomekling commented 1 year ago

I don't think translations are appropriate at this stage.

UI strings are going to change over and over again, and I don't want to turn the project into an endless stream of "update XYZ language" commits.