search

LadybirdBrowser / ancient-history

The Ladybird web browser
BSD 2-Clause "Simplified" License
1.62k stars 107 forks source link

Ladybird: fix all memory leaks fonud by valgrind #80

Closed diegoiast closed 1 year ago

diegoiast commented 1 year ago

Seems like we created QActions without parents. Easy to fix.

I found no other issues. Run the browser on the home page, github... and saw no new leaks nor out of bounds... seems like libweb is quite clean.

FireFox317 commented 1 year ago

A better commit title would be: Ladybird: Add parent to QActions, and then in the message you could explain that this fixes memory leaks found by Valgrind.