Open kuchikuu opened 22 hours ago
I've got some other grid fixes in the works already. I'll see if they fix this issue too.
EDIT: After watching that video and studying the screenshots more closely it seems unlikely to be related to my current work. I'll still give it a shot though.
Probably huge huge connection to https://github.com/LadybirdBrowser/ladybird/issues/1812
Description: Website https://lichess.org has two buttons. "Donate" and "Swag store". These two buttons get stretched when opened in Ladybird. I created a (somewhat) minimal html code to reproduce the effect.
Information about the host system and the version of the browser: OS: Debian GNU/Linux 12 (bookworm) x86_64 Kernel: 6.1.0-17-amd64 Compiler: gcc (GCC) 14.2.0 Build command: ./Meta/ladybird.sh run ladybird Head commit when compiling:
44b1c4f2b59563cf29f6af81bb86645f2fa89155
More details: The website changes its layout depending on the window's size. The buttons remain in the correct size when the window size is small/medium. But when the width of the window is bigger, then the layout adjusts and the buttons get stretched. (if your browser crashes when you try to scroll down the lichess.org page, disable javascript and then open the page again) I assume this is a Grid issue, as out of hundreds of lines of CSS, grid related code is what's mostly left.
https://github.com/user-attachments/assets/fc6cffaa-4a71-440f-ab81-c8bfac38586a
Minimal code to reproduce the bug:
Body but with classes. It doesn't change anything, but maybe it will help understand what the divs are for. There are divs that are closed but not even opened so I don't know.
I was simply deleting code as long as the bug persisted.
Screenshots:
Firefox: (different board color is because I am logged in)
Ladybird:
Video demo:
https://github.com/user-attachments/assets/38ba7066-4fd6-44be-9328-3a4a4acd8333
I hope this will help someone. Good luck.