LadybirdBrowser / ladybird

Truly independent web browser
https://ladybird.org
BSD 2-Clause "Simplified" License
22.43k stars 1k forks source link

`Text/input/wpt-import/css/css-flexbox/text-as-flexitem-size-001.html` is flaky #2341

Open AtkinsSJ opened 2 weeks ago

AtkinsSJ commented 2 weeks ago

Seen on CI occasionally, but I've also had it happen locally on macOS once or twice. It's rare. Disabled in #2342.

--- /home/runner/work/ladybird/ladybird/Tests/LibWeb/Text/expected/./wpt-import/css/css-flexbox/text-as-flexitem-size-001.txt
+++ /home/runner/work/ladybird/ladybird/Tests/LibWeb/Text/expected/./wpt-import/css/css-flexbox/text-as-flexitem-size-001.txt
@@ -6,20 +6,19 @@

 Found 18 tests

-13 Pass
-5 Fail
+18 Pass
 Details
-Result Test Name   MessageFail .flexbox > div 1    
-Fail   .flexbox > div 2    
+Result Test Name   MessagePass .flexbox > div 1    
+Pass   .flexbox > div 2    
 Pass   .flexbox > div 3    
 Pass   .flexbox > div 4    
-Fail   .flexbox > div 5    
+Pass   .flexbox > div 5    
 Pass   .flexbox > div 6    
 Pass   .flexbox > div 7    
-Fail   .flexbox > div 8    
+Pass   .flexbox > div 8    
 Pass   .flexbox > div 9    
 Pass   .flexbox > div 10   
-Fail   .flexbox > div 11   
+Pass   .flexbox > div 11   
 Pass   .flexbox > div 12   
 Pass   .flexbox > div 13   
 Pass   .flexbox > div 14
AtkinsSJ commented 2 weeks ago

It @imports a font, so seems likely that not waiting is the cause of the flake.