search

LadybirdBrowser / ladybird

Truly independent web browser
https://ladybird.org
BSD 2-Clause "Simplified" License
22.27k stars 987 forks source link

LibWeb: Fix `get_attribute` logic for lowercase comparisons #2498

Closed F3n67u closed 13 hours ago

F3n67u commented 14 hours ago

Resolved an issue where equals_ignoring_ascii_case was incorrectly used for lowercase comparisons.

This patch fixes 2 WPT subtests related to attribtues lowercase handling.

Tests/LibWeb/Text/input/wpt-import/dom/nodes/attributes.html: from 3 fails to 1 fail

Gingeh commented 13 hours ago

Just FYI this is now the third open PR that includes this change (see #2469 and #2478, both opened yesterday)

F3n67u commented 13 hours ago

Just FYI this is now the third open PR that includes this change (see #2469 and #2478)

oops, then let us close this one and in favor of others.