search

LadybirdBrowser / ladybird

Truly independent web browser
https://ladybird.org
BSD 2-Clause "Simplified" License
12.52k stars 501 forks source link

Move New Tab button in tab bar #252

Open sohzm opened 3 weeks ago

sohzm commented 3 weeks ago

The "New Tab" button is positioned in the toolbar, unlike Firefox and Chrome, where it's integrated directly into the tab bar.

I've attached screenshots for comparison:

Screenshot from 2024-06-23 04-14-07

Screenshot from 2024-06-23 04-23-36

I propose moving the "New Tab" button to the tab bar.

I'm ready to work on this adjustment if the team (or someone) agrees it's a worthwhile update.

lukewarlow commented 3 weeks ago

Interestingly I think Ladybird's layout is the same Gnome web browser (WebKit for Linux), and Safari. So it's not completely an odd one out.

trflynn89 commented 3 weeks ago

Yeah, I wanted to put that button in the tab bar when I originally added it, but wasn't able to get it to look nice, so I put it next to the URL bar. See: https://discord.com/channels/830522505605283862/830525031720943627/1225570437665259625

unworld11 commented 3 weeks ago

can this issue be assigned to me?

proJM-Coding commented 1 week ago

I would prefer a one line setup like I have with firefox.

image

It saves space and looks modern.

GeneralChauhan commented 1 week ago

https://discord.com/channels/830522505605283862/830525031720943627/1225570437665259625

I cannot open this for some reason, can you copy the image?

I will pick this up and check it.

sohzm commented 1 week ago

@GeneralChauhan join SerenityOS discord server to view it: https://discord.com/invite/serenityos

GeneralChauhan commented 1 week ago

Got it. Thanks 🙏

theonlyasdk commented 1 week ago

I would prefer a one line setup like I have with firefox.

image

It saves space and looks modern.

What about people who are on low resolution/small screens?

theonlyasdk commented 1 week ago

The "New Tab" button is positioned in the toolbar, unlike Firefox and Chrome, where it's integrated directly into the tab bar.

I've attached screenshots for comparison:

Screenshot from 2024-06-23 04-14-07

Screenshot from 2024-06-23 04-23-36

I propose moving the "New Tab" button to the tab bar.

I'm ready to work on this adjustment if the team (or someone) agrees it's a worthwhile update.

Yes, something like this would be nice especially when its location is configurable just like the hamburger menu

proJM-Coding commented 1 week ago

I would prefer a one line setup like I have with firefox. image It saves space and looks modern.

What about people who are on low resolution/small screens?

That is a bit of a problem actually, I didn't think of that. When the window is small though it goes back to normal.

image

Here is the github for it if interested: https://github.com/crambaud/waterfall