LadybirdBrowser / ladybird

Truly independent web browser
https://ladybird.org
BSD 2-Clause "Simplified" License
13.38k stars 537 forks source link

Dependencies: vcpkg-provided gn's jemalloc does not use 16 KiB pages on Asahi Linux #261

Open ADKaster opened 1 month ago

ADKaster commented 1 month ago

As reported to me privately, building on Asahi linux (or any other 16 KiB page Linux distro) seems to run into trouble with Skia's jemalloc.

We should fix this by providing the proper configure flags to Skia/jemalloc, or possibly opening a PR upstream to vcpkg to fix this.

ADKaster commented 1 month ago
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:112 (message):
    Command failed: /home/a
    ndrew/Source/ladybird/Build/ladybird/vcpkg_installed/arm64-linux/tools/gn/gn gen /home/andrew/Source/ladybird/Toolchain/Tarballs/vcpkg/buildtrees/skia/arm64-linux-dbg "--args=target_cpu=\"arm64\" skia_enable_android_utils=false skia_enable_spirv_validation=false skia_enable_tools=false skia_enable_gpu_debug_layers=false skia_use_jpeg_gainmaps=false skia_use_libheif=false skia_use_lua=false is_component_build=false skia_use_fontconfig=true skia_use_freetype=true skia_use_harfbuzz=true skia_use_icu=true skia_use_gl=true         cc=\"/usr/lib64/ccache/cc\"         cxx=\"/usr/lib64/ccache/c++\" is_debug=true     extra_cflags_c=[\"-fPIC\",\"-g\"]     extra_cflags_cc=[\"-fPIC\",\"-g\"]"
    Working Directory: /home/andrew/Source/ladybird/Toolchain/Tarballs/vcpkg/buildtrees/skia/src/1c27019d33-728a6df320.clean
    Error code: Subprocess aborted
    See logs for more information:
      /home/andrew/Source/ladybird/Toolchain/Tarballs/vcpkg/buildtrees/skia/generate-arm64-linux-dbg-err.log

The contents of that error log are simply:

~/Source/ladybird$ cat /home/andrew/Source/ladybird/Toolchain/Tarballs/vcpkg/buildtrees/skia/generate-arm64-linux-dbg-err.log
<jemalloc>: Unsupported system page size
<jemalloc>: Unsupported system page size
<jemalloc>: Unsupported system page size
<jemalloc>: Unsupported system page size
<jemalloc>: Unsupported system page size

This suggests to me that perhaps the issue is actually in the vcpkg build of the host tool for gn ?

ADKaster commented 1 month ago

https://github.com/microsoft/vcpkg/issues/39468