LibWeb: Replace all direct uses of ResourceLoader with Fetch - Githubissues

LadybirdBrowser / ladybird

Truly independent web browser

https://ladybird.org

BSD 2-Clause "Simplified" License

22.99k stars 1.02k forks source link

LibWeb: Replace all direct uses of ResourceLoader with Fetch #2634

Open Lubrsi opened 3 days ago

Lubrsi commented 3 days ago

We should replace all direct uses of ResourceLoader with Fetch. This is because using ResourceLoader bypasses many features that Fetch handles:

All security mechanisms (CORS-preflight, Mixed Content, Content Security Policy, bad ports, Sec-Fetch-* headers, Referrer Policy, etc.)
Service Workers (not yet implemented)
Caching
Redirects
Blob URLs
Resource Timing (not yet implemented, required for #226)
Referrers
More that I can't think as of writing.

These are the usages I could find:

[ ] HTMLLinkElement https://github.com/LadybirdBrowser/ladybird/blob/ac590fe30d9631cec2069b3fbb9bb69e78ef7bda/Libraries/LibWeb/HTML/HTMLLinkElement.cpp#L77-L91
[ ] Font Loading in StyleComputer.cpp https://github.com/LadybirdBrowser/ladybird/blob/ac590fe30d9631cec2069b3fbb9bb69e78ef7bda/Libraries/LibWeb/CSS/StyleComputer.cpp#L246-L252
[ ] CSSImportRule https://github.com/LadybirdBrowser/ladybird/blob/ac590fe30d9631cec2069b3fbb9bb69e78ef7bda/Libraries/LibWeb/CSS/CSSImportRule.cpp#L36-L43
[ ] HTMLObjectElement https://github.com/LadybirdBrowser/ladybird/blob/ac590fe30d9631cec2069b3fbb9bb69e78ef7bda/Libraries/LibWeb/HTML/HTMLObjectElement.cpp#L211-L216

With these replaced, we could remove load_resource and potentially badge load and load_unbuffered to only be called from Fetch.

shlyakpavel commented 3 days ago

This one https://wpt.fyi/results/infrastructure/assumptions/blank.html Might be failing quite a few tests for us. Does HTMLLinkElement using fetch cover <link rel=match href="about:blank">?