search

LadybirdBrowser / ladybird

Truly independent web browser
https://ladybird.dev
BSD 2-Clause "Simplified" License
4.33k stars 215 forks source link

LibWeb: `css-keyframe-fill-forwards.html` test causes intermittent CI failures #296

Open tcl3 opened 4 days ago

tcl3 commented 4 days ago

The css-keyframe-fill-forwards.html ref test is currently causing intermittent CI failures.

It also fails consistently for me locally (on Ubuntu).

I've bisected this issue to: be2c484

The test fails with the following JS error:

WebContent(195063): Unhandled JavaScript exception: [TypeError] Cannot access property "currentTime" on undefined object "[0]"
WebContent(195063):     at file:///home/tim/repos/ladybird/Tests/LibWeb/Ref/css-keyframe-fill-forwards.html:2:49

CC: @mattco98, @kalenikaliaksandr

nico commented 3 days ago

I think I've seen this on serenity CI, and we haven't merged the commit you bisected to. We did merge mattco's recent two web animation PRs.

(Not 100% sure it was this test though)

nico commented 3 days ago

...nope, it was a different test. I found the button to look at old CI results (it doesn't exist in the mobile webui afaict): https://github.com/SerenityOS/serenity/actions/runs/9696181167/job/26759412046?pr=24606