search

LadybirdBrowser / ladybird

Truly independent web browser
https://ladybird.org
BSD 2-Clause "Simplified" License
22.35k stars 992 forks source link

JS: Test failure: DisplayNames reports "Islamic calendar" with ICU < 74 #411

Closed sideeffect42 closed 4 months ago

sideeffect42 commented 4 months ago

When Ladybird is linked against ICU < 74.1 the islamic calendar is called "Islamic Calendar" instead of "Hijri calendar".

This results in a test failure:

 FAIL  builtins/Intl/DisplayNames/DisplayNames.prototype.of.js                                                                                                                                                    
    ❌ Suite:  correct behavior
         Test:   option type calendar (failed):                                                                                                                                                                   
                 ExpectationError: toBe: expected _Hijri Calendar_, got _Islamic Calendar_

Ladybird js:

> new Intl.DisplayNames("en", { type: "calendar" }).of("islamic");
"Islamic Calendar"

The same also applies to Firefox and WebKitGTK:

Firefox:

> new Intl.DisplayNames("en", { type: "calendar" }).of("islamic")
"Islamic Calendar"

WebKitGTK (jsc):

new Intl.DisplayNames("en", { type: "calendar" }).of("islamic");
>>> "Islamic Calendar"

https://github.com/unicode-org/icu/releases/tag/release-74-1 https://cldr.unicode.org/index/downloads/cldr-44

trflynn89 commented 4 months ago

We are not going to support having our tests pass with old versions of the CLDR. Similarly, test262 does not bother supporting old versions. We specify the version we support with vcpkg.