LadybirdBrowser / ladybird

Truly independent web browser
https://ladybird.org
BSD 2-Clause "Simplified" License
19.35k stars 784 forks source link

Ladybird/Qt: TabBar doesn't extend the whole window width #768

Open jamierocks opened 1 month ago

jamierocks commented 1 month ago

image image

See the line that runs under the tab bar.

simonkrauter commented 1 month ago

Introduced in https://github.com/LadybirdBrowser/ladybird/pull/629 with the line m_tabs_container->tabBar()->setMaximumWidth(window_width - 32);.

circl-lastname commented 1 month ago

That is kinda intentional to reserve space for the New Tab button when the tab bar is full, but it doesn't play nice with themes clearly

jamierocks commented 1 month ago

image

This still doesn't look right, or extend the full width.

AtkinsSJ commented 1 month ago

That's really odd. I can't believe this is so complicated. 😅