fix: never mark confetti particles as stopped, so they dont stick to ceilings or persist floating when the floor is removed

Ladysnake / BLAST

A simple Minecraft bomb mod for Fabric.

https://ladysnake.github.io/wiki/blast.html

13 stars 14 forks source link

fix: never mark confetti particles as stopped, so they dont stick to ceilings or persist floating when the floor is removed #45

Closed williambl closed 8 months ago

williambl commented 10 months ago

closes #30 closes #31

Some code is copied from Particle.java. An alternative solution would involve an access widener or accessor mixin to access the stopped field from inside ConfettiParticle#tick. However, that felt like overkill when this solution was available without using any 'coremodding'.

Pyrofab commented 10 months ago

Thank you ! But to be honest I do prefer the mixin way, it seems like it would be a lot less annoying to maintain.

williambl commented 10 months ago

Alright, will change that.

williambl commented 10 months ago

Changed :)

williambl commented 10 months ago

yes :)