search

Ladysnake / Dissolution-Legacy

1.12 version of Requiem
3 stars 2 forks source link

Compatibility with Angel of Vengeance, Special Mobs and Dynamic Sword Skills #2

Open Jackiecrazy opened 5 years ago

Jackiecrazy commented 5 years ago

Special mobs are not being registered as undead for some reason, had to cheat in a GoG vampire when testing, which caused height issues. Besides that, angel of vengeance aoe spells and nimbus rays will target your host, and DSS will permanently lock your orientation to straight up (perhaps because the spirit is aiming at the host)

Pyrofab commented 5 years ago

Mobs not being possessable is on them, it means they either did not declare their mob as undead (smite weapons won't work either), or they declared it as a boss. Either way you should be able to add them to the whitelist in the config. Height issues will be fixed in 1.14 (sorry, not before). The DSS issue could be easily solved on their side by using the API to check if an entity is possessed before targeting it.

Jackiecrazy commented 5 years ago

Hum. Alright, that makes sense. What's odd, though, is that special mobs are definitely declared as undead. Harming/healing is inverted and they're protected by consecration out of the box. Anyway I added them to the config and I'll move the other issues to their own mod githubs, this is just kind of a heads up thing. Speaking of which, does the whitelist act as a literal whitelist or is it an "additional possessable mobs" kind of whitelist? Do I have to add all the vanilla mobs and mobs that work out of the box as well?

Pyrofab commented 5 years ago

It's an additive whitelist.

Jackiecrazy commented 5 years ago

Hmm... no. Even when I add them to the whitelist, I still cannot possess them. Logs aren't outputting anything, either. They are undead and not bosses, I checked.

Pyrofab commented 5 years ago

I forgot, there is another condition, which is that they must be derived from the hostile mob class. It's my fault for not logging more stuff to be honest.

Jackiecrazy commented 5 years ago

That's... even stranger then. As far as I know, they all extend their respective base classes (e.g. fire zombie extends EntityZombie)

sschr15 commented 4 years ago

TODO allow non-hostile mobs to be possessed (probably with a config option)