search

Ladysnake / Effective

A Minecraft Quilt client-side mod adding ambient and environmental interaction effects to enhance immersion.
Other
199 stars 65 forks source link

Random Client Crashes from players on SMP #177

Closed fzzyhmstrs closed 1 year ago

fzzyhmstrs commented 1 year ago

In the Timefall SMP, the modpack we are running includes Effective. A few times now we've gotten reports of client crashes with logs that all seem to have a common source. Here is an example log, and the snippet of it that shows something about WaterfallCloudGenerators.

Example log: crash-2023-05-03_22.07.28-client.txt

Snippet:

java.lang.NullPointerException: Cannot invoke "net.minecraft.class_2680.method_26227()" because the return value of "net.minecraft.class_2841.method_12321(int, int, int)" is null
    at net.minecraft.class_2826.method_12255(class_2826.java:55)
    at net.minecraft.class_2818.method_12234(class_2818.java:753)
    at net.minecraft.class_2818.method_8316(class_2818.java:198)
    at net.minecraft.class_1937.method_8316(class_1937.java:379)
    at ladysnake.effective.client.world.WaterfallCloudGenerators.shouldCauseWaterfall(WaterfallCloudGenerators.java:91)
    at ladysnake.effective.client.world.WaterfallCloudGenerators.addGenerator(WaterfallCloudGenerators.java:32)
    at net.minecraft.class_775.handler$cld000$effective$generateWaterfall(class_775.java:519)
    at net.minecraft.class_775.method_3347(class_775.java)
    at net.minecraft.class_776.method_3352(class_776.java:75)
    at net.minecraft.class_846$class_851$class_4578.method_22785(class_846.java:566)
    at net.minecraft.class_846$class_851$class_4578.method_22783(class_846.java:489)
    at net.minecraft.class_846.method_22757(class_846.java:140)
    at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1768)
    at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.exec(CompletableFuture.java:1760)
    at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
    at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182)
    at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655)
    at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622)
    at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)