search

Ladysnake / Effective

A Minecraft Quilt client-side mod adding ambient and environmental interaction effects to enhance immersion.
Other
203 stars 66 forks source link

PR's for new versions? #180

Closed SzczurekYT closed 1 year ago

SzczurekYT commented 1 year ago

Y'all have no idea how much effort Rat spends on his daytime job, please stop being so dismissive when it comes to a mod he updates on the time he has left after that. It is okay to be pained because a mod you like is in a state of stasis, but it is not acceptable to dogpile on the creator in hopes that they will cave at the cost of their mental health.

I will be closing this issue as it was pretty much destined to be a repository for complaints.

Originally posted by @Pyrofab in https://github.com/Ladysnake/Effective/issues/179#issuecomment-1582852640

Hello I see that some of the Ladysnake mods are stale, with creators not having time to update it. That's understandable. I would like to ask if you are interested in accepting / reviewing PR's that update these mods to new versions? Because I think I could maybe update some of them for you. I already made a PR for Impaled for 1.19.3 (oh wait it has conflicts now, need to fix that), and I have also Blast for 1.19.3, on my pc. Now I might update Effective to 1.19.4, as it was a cool mod, and I miss it. Would you be interested in this?

Pyrofab commented 1 year ago

Hm, fair enough, I can at least review it and merge it if you do the PR. The release part will still most likely have to wait for RAT though.

SzczurekYT commented 1 year ago

Hm, fair enough, I can at least review it and merge it if you do the PR. The release part will still most likely have to wait for RAT though.

I made it 😄 https://github.com/Ladysnake/Effective/pull/181

peepeepoopoocaca commented 1 year ago

I made it 😄 #181

Will you also be doing a version for 1.20, or are you strictly sticking to 1.19.4? Thanks.

doctor4t commented 1 year ago

Y'all have no idea how much effort Rat spends on his daytime job, please stop being so dismissive when it comes to a mod he updates on the time he has left after that. It is okay to be pained because a mod you like is in a state of stasis, but it is not acceptable to dogpile on the creator in hopes that they will cave at the cost of their mental health.

I will be closing this issue as it was pretty much destined to be a repository for complaints.

Originally posted by @Pyrofab in #179 (comment)

Hello I see that some of the Ladysnake mods are stale, with creators not having time to update it. That's understandable. I would like to ask if you are interested in accepting / reviewing PR's that update these mods to new versions? Because I think I could maybe update some of them for you. I already made a PR for Impaled for 1.19.3 (oh wait it has conflicts now, need to fix that), and I have also Blast for 1.19.3, on my pc. Now I might update Effective to 1.19.4, as it was a cool mod, and I miss it. Would you be interested in this?

Hi! Yeah sorry, I tend to be so busy I can't check this repo at all, even when it comes to merging PRs. If you wanna PR some updates I wouldn't be against it, but sometimes I'm so busy I can't even check that, but it would be appreciated. I'll do my best!