Port to 1.20.1

[Motschen]

Based on @SzczurekYT 's 1.19.4 PR (#199) I also changed the config screen to use MidnightConfig's new tab system instead on the comments for categories.

[SzczurekYT]

Nice to see that my work is useful, I hope Rat will make an official release soon. 👍

[Raph4106]

I cannot modify the In Game configs with this port, is it normal behaviour since it's not an official release? edit: nvm I can't even see the mod's feature...

[Motschen]

I cannot modify the In Game configs with this port, is it normal behaviour since it's not an official release? edit: nvm I can't even see the mod's feature...

It all worked just fine in my testing. The config not being accessible via ModMenu seems to be an issue with ModMenu itself not correctly using it's API for libraries anymore, thus causing MidnightLib's automatic ModMenu integration to not work properly in some cases. While I investigate this further, you can set libraries to be shown in ModMenu, go to MidnightLib's config and setting 'Config Screen List' to Yes. Then, you'll be able to open the config via the options screen.

[PabloDubalom]

How to download or there is no file yet?

[Motschen]

How to download or there is no file yet?

You can download my compiled version here: https://github.com/Motschen/Effective/releases/download/2.1.1%2B1.20/effective-2.1.1+1.20.1.jar

[PabloDubalom]

How to download or there is no file yet?

You can download my compiled version here: https://github.com/Motschen/Effective/releases/download/2.1.1%2B1.20/effective-2.1.1+1.20.1.jar

Thank you very much

[MotMomet]

How to download or there is no file yet?

You can download my compiled version here: https://github.com/Motschen/Effective/releases/download/2.1.1%2B1.20/effective-2.1.1+1.20.1.jar

hey my game just crashes when i enter my world. I use 1.20. Is it the reason?

[MotMomet]

i can't join in 1.20.1 aswell

java.lang.NullPointerException: Cannot read field "field_44912" because "this.field_4015.field_1724" is null at net.minecraft.class_757.method_3188(class_757.java:1085) at net.minecraft.class_757.method_3192(class_757.java:880) at net.minecraft.class_310.method_1523(class_310.java:1219) at net.minecraft.class_310.method_1514(class_310.java:802) at net.minecraft.client.main.Main.main(Main.java:250) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:568) at org.quiltmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:524) at org.quiltmc.loader.impl.launch.knot.Knot.launch(Knot.java:82) at org.quiltmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:28)

[doctor4t]

Thanks a lot for the contribution, I'll see if I get time to test it and release it. Question, does it fix any of the issues the original PR this is based on had?

[Happyrobot33]

Just for anyone coming across this you need midnightlib installed https://modrinth.com/mod/midnightlib/version/1.4.1-fabric

[5akura]

Just for anyone coming across this you need midnightlib installed https://modrinth.com/mod/midnightlib/version/1.4.1-fabric

Thank you, it works!

[syns]

How to download or there is no file yet?

You can download my compiled version here: https://github.com/Motschen/Effective/releases/download/2.1.1%2B1.20/effective-2.1.1+1.20.1.jar

Thank you!!! I have been waiting so long to try Effective with my preferred mod setup!

[TechMasterApp]

Thanks a lot for the contribution, I'll see if I get time to test it and release it. Question, does it fix any of the issues the original PR this is based on had?

I've tested the mod and it works perfectly. When would the release be coming out?

[MrCookie112]

How do you modify the parameters of the mod? Is it normal that I'm not getting the effects, such as fireflies, for example?

[ArcticWarmth]

i can't join in 1.20.1 aswell

java.lang.NullPointerException: Cannot read field "field_44912" because "this.field_4015.field_1724" is null at net.minecraft.class_757.method_3188(class_757.java:1085) at net.minecraft.class_757.method_3192(class_757.java:880) at net.minecraft.class_310.method_1523(class_310.java:1219) at net.minecraft.class_310.method_1514(class_310.java:802) at net.minecraft.client.main.Main.main(Main.java:250) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:568) at org.quiltmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:524) at org.quiltmc.loader.impl.launch.knot.Knot.launch(Knot.java:82) at org.quiltmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:28)

This error seems to be related so having sodium installed. Mod works flawlessly when installed alone (with QFAPI and midnightconfig). This PR might introduce an incompatibility with sodium and other related mods

EDIT: Crash is related to versions of sodium prior to 5.0

[SuperNoobYT]

Effective doesn't work very well with shader (i only tried this pr with shader as well as old versions of effective and illumination, wich worked fine with shaders)

Firefly, will o wisp, improved fireball, spectral arrow trail, allay trail, glowsquid particles and dragon breath are invisible using a shaders with iris + sodium.

I tested BSL shader, complementary reimagine and sildur vibrant.

[Spike-has-no-idea-how-to-code]

Effective doesn't work very well with shader (i only tried this pr with shader as well as old versions of effective and illumination, wich worked fine with shaders)

Firefly, will o wisp, improved fireball, spectral arrow trail, allay trail, glowsquid particles and dragon breath are invisible using a shaders with iris + sodium.

I tested BSL shader, complementary reimagine and sildur vibrant.

I have this too, I thought something was missing

[SuperNoobYT]

I just tested effective 2.1.1 - 1.19.2 release with sodium and iris and it work fine with shaders.

[YkVox]

How do you modify the parameters of the mod? Is it normal that I'm not getting the effects, such as fireflies, for example?

it seems there's no support for modconfig yet, but you can change it manually in the config folder refer to this file for the options: src/main/java/ladysnake/effective/EffectiveConfig.java

[SzczurekYT]

If this one is mergeable then the 1.19.4 sould be good too, since this one is based on the 1.19.4 one. It only has one issue where the splashes are centered on a block, and not on the position something hit the water. I will try to find some time to fix it in the coming week. There were also building issues due to a broken jitpack build.

[Spike-has-no-idea-how-to-code]

No i cant see anything with shaders except for water splashes and cascades, there is a problem

[Raph4106]

Everything works fine and Gucci until I enter any water sources and crash... Any idea which log would be ideal to throw here?

Edit: crash specifically happen while I play on my friend group server and only happens if I specifically enter a water source. Everybody and anything else works just fine.

[SzczurekYT]

The crash log would probably work.

[Raph4106]

The crash log would probably work.

Well, which? The vanilla one?

[Raph4106]

The crash log would probably work.

https://gist.github.com/Raph4106/64facf769bedbee7802b32d238c86d33

Here, I dunno if it's the right log you wanted but if it isn't please make sure to tell me. btw, Effective is the actual cause of the crash, as if I uninstall it the crash no longer occurs.

[MANSPREADER69]

If this one is mergeable then the 1.19.4 sould be good too, since this one is based on the 1.19.4 one. It only has one issue where the splashes are centered on a block, and not on the position something hit the water. I will try to find some time to fix it in the coming week. There were also building issues due to a broken jitpack build.

yeah I get the same problem with the splashes, have you found anything?

[jh-devv]

Would be nice to see 1.20.2 when possible!

[Raph4106]

The crash log would probably work.

https://gist.github.com/Raph4106/64facf769bedbee7802b32d238c86d33

Here, I dunno if it's the right log you wanted but if it isn't please make sure to tell me. btw, Effective is the actual cause of the crash, as if I uninstall it the crash no longer occurs.

I'm guessing nobody will look into a bug from 3 weeks to almost a month old...

[jh-devv]

Would be nice to see 1.20.2 when possible!

Quilt apis not ported yet, soooo idk

[KingBOIII365]

When upgrading to FabricAPI 0.88 or more? #

How to download or there is no file yet?

You can download my compiled version here: https://github.com/Motschen/Effective/releases/download/2.1.1%2B1.20/effective-2.1.1+1.20.1.jar

Thank you!!! I have been waiting so long to try Effective with my preferred mod setup!

[JackDeLexus]

To anyone that wanna change the setting, but since this version didn't have the settings, and If you're on Windows, Go to your Minecraft folder, then go to "config", and then open "effective.json". On there, you can change the settings however you want.

But, Since You might not know what choices you need since not all of them are just "YES" or "NO", You need to open the mod file with WinRar, go to "ladysnake", then "effective", then find any file that starts up with "EffectiveConfig$" and ends with "Options.class", and then open that file with either Notepad or Notepad++. In that file, Find the option that you wanna change, and find the selection that the option has. After you find the setting that you want, Go to the config file, and then change the setting that you wanna change. There you go.

Here's one of the example. I tried to disable the Glow Squid hypno effect, but This version doesn't have an option menu, so I decided to find the config and change it.

[Shad0wolf0]

To anyone that wanna change the setting, but since this version didn't have the settings, and If you're on Windows, Go to your Minecraft folder, then go to "config", and then open "effective.json". On there, you can change the settings however you want.

You can change the settings in-game as Motschen already mentioned

It all worked just fine in my testing. The config not being accessible via ModMenu seems to be an issue with ModMenu itself not correctly using it's API for libraries anymore, thus causing MidnightLib's automatic ModMenu integration to not work properly in some cases. While I investigate this further, you can set libraries to be shown in ModMenu, go to MidnightLib's config and setting 'Config Screen List' to Yes. Then, you'll be able to open the config via the options screen.

[MrCookie112]

Hallo, Some visual effects are not compatible with the shader I'm using. I have tested this issue with the shader as well as with the previous versions of Effective and Illumination, which worked well with shaders.

I notice the absence of particles for Firefly, Will-o'-Wisp, enhanced fireball, spectral arrow trail, allay trail, Glowsquid, and dragon breath when I activate a shader with Iris + Sodium. Do you have any solutions to suggest?

[Its-Just-Luci]

is it just not loading for anyone else? like the mods not even visible as installed...

[DroidZed]

Any news ?

[Pyrofab]

Yes, I think it is high time we merge this - enough people have tested it already 👍

[MotMomet]

i can't join in 1.20.1 aswell java.lang.NullPointerException: Cannot read field "field_44912" because "this.field_4015.field_1724" is null at net.minecraft.class_757.method_3188(class_757.java:1085) at net.minecraft.class_757.method_3192(class_757.java:880) at net.minecraft.class_310.method_1523(class_310.java:1219) at net.minecraft.class_310.method_1514(class_310.java:802) at net.minecraft.client.main.Main.main(Main.java:250) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:568) at org.quiltmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:524) at org.quiltmc.loader.impl.launch.knot.Knot.launch(Knot.java:82) at org.quiltmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:28)

This error seems to be related so having sodium installed. Mod works flawlessly when installed alone (with QFAPI and midnightconfig). This PR might introduce an incompatibility with sodium and other related mods

EDIT: Crash is related to versions of sodium prior to 5.0

hey thanks man!

[Anoaxx]

Cant wait for 1.20.4