Ladysnake / Effective

A Minecraft Quilt client-side mod adding ambient and environmental interaction effects to enhance immersion.
Other
199 stars 65 forks source link

Splashes are centered on blocks #243

Open SPINZ1 opened 3 months ago

SPINZ1 commented 3 months ago

When the mod was on fabric, splashes appeared exactly where entities landed:

https://github.com/Ladysnake/Effective/assets/145732023/9cd8323f-9c94-4a5f-b72a-bfb47e21b410

Now, on quilt, the splashes are locked to the block grid:

https://github.com/Ladysnake/Effective/assets/145732023/7bd4984c-be4a-482c-a9d0-44084d74355b

DarksideAlex commented 2 months ago

Note to devs: It seems like the problem is not with the water splash function itself, but rather the input values.

DarksideAlex commented 2 months ago

Update: I got a feeling that it has to do with quilts entity.getX() and entity.getY() outputs. They are supposed to be doubles, but it's the only reasonable cause to me at the moment.