search

Ladysnake / Effective

A Minecraft Quilt client-side mod adding ambient and environmental interaction effects to enhance immersion.
Other
213 stars 68 forks source link

Effective causing a game crash! #40

Closed JustAHuman-xD closed 2 years ago

JustAHuman-xD commented 2 years ago

Something is happening with effective that is causing a game crash: image

Crash Report: https://paste.gg/p/anonymous/58521a75616841c398a638887744ee2c

If you need a mod list I can post it

AViewFromTheTop commented 2 years ago

same

srnyx commented 2 years ago

Here's a crashy of it: https://crashy.net/lLUmRgjwavGOrOkpKVOT

theDerpu commented 2 years ago

yup, same here

theDerpu commented 2 years ago

crashing even with just vanilla so it is Effective doing it, I think the HashMap error that is the problem, I have no idea how to fix it myself so we will just have to wait for now I suppose.

rbroderi commented 2 years ago

im getting the same issue.

rbroderi commented 2 years ago

looks like it is cause by public static final Set generators in src\main\java\ladysnake\effective\client\world\WaterfallCloudGenerators.java hashset modified in non thread safe manner.

rbroderi commented 2 years ago

just tested out using CopyOnWriteArraySet instead of the Hashset and that seems to resolve this issue as the CopyOnWriteArraySet is thread safe.