Ladysnake / Effective

A Minecraft Quilt client-side mod adding ambient and environmental interaction effects to enhance immersion.
Other
200 stars 65 forks source link

java.lang.ConcurrentModificationException in waterfall effect rendering (seemingly random) #71

Closed NathanDSimon closed 2 years ago

NathanDSimon commented 2 years ago

I keep crashing when using this mod in my pack; according to the crash log it appears to be related to something in the tick() function of your waterfall cloud generators. Here's the stacktrace: java.util.ConcurrentModificationException at java.base/java.util.HashMap$HashIterator.nextNode(HashMap.java:1597) at java.base/java.util.HashMap$KeyIterator.next(HashMap.java:1620) at ladysnake.effective.client.world.WaterfallCloudGenerators.tick(WaterfallCloudGenerators.java:34) at ladysnake.effective.client.Effective.lambda$onInitializeClient$2(Effective.java:121) at net.fabricmc.fabric.api.client.event.lifecycle.v1.ClientTickEvents.lambda$static$6(ClientTickEvents.java:111) at net.minecraft.class_638.handler$ckh000$tickWorldAfterBlockEntities(class_638.java:3600) at net.minecraft.class_1937.method_18471(class_1937.java:483) at net.minecraft.class_638.method_18116(class_638.java:205) at net.minecraft.class_310.method_1574(class_310.java:1751) at net.minecraft.class_310.method_1523(class_310.java:1086) at net.minecraft.class_310.method_1514(class_310.java:733) at net.minecraft.client.main.Main.main(Main.java:238) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:568) at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:416) at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:77) at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23

I've also linked the crash log to this issue. crash-2022-03-03_12.22.00-client.txt )