Closed lonefelidae16 closed 1 year ago
Looks like this would fix exactly the issue I'm having:
Looks like this would fix exactly the issue I'm having
Thank you for testing and reporting back. Would you please tell us about your testing environment?
Looks like this would fix exactly the issue I'm having
Thank you for testing and reporting back. Would you please tell us about your testing environment?
In my case it's a massive modpack of 250+ mods. I have no idea what a minimal reproduction case would be, but here is a fairly recent mods list (when it was still happening):
Sorry, I didn’t word it well enough. Since this PR is due to a GPU driver issue, I wanted to know what information is listed in the ‘Display’ section that can be seen by pressing the F3 key. In my case it is ‘Intel HD Graphics 520 with MESA Driver’. I think this PR will be easier to merge once reports of it working with various types of drivers are collected. Thank you very much.
Ah, okay, I will get that screenshot in just a moment!
Here we are:
I didn’t think the NVIDIA driver had anything to do with it, but I see that the RTX 2070 SUPER was also having this problem. Maybe it really is a hardware compatibility issue. Thank you for taking your time, Brittank88!
Oh just to clarify, did you think I was testing your PR? My screenshots are from the normal latest release of Effective. I can totally test your PR though, if you want!
Oh just to clarify, did you think I was testing your PR? My screenshots are from the normal latest release of Effective. I can totally test your PR though, if you want!
Apparently I am confused. In response to your statement ‘Looks like this would fix exactly’, I assumed that you had fully tested this PR. I am very sorry for the misunderstanding that seems to have arisen from this.
Of course I too would like to see more results from this PR test, but I also know the complexity of the procedure to test it. ~So I have decided to attach a built jar with this change to make it easier to test it in the future. This can be seen in my repository: lonefelidae16:Effective/fix/black-splashes~ If you don’t mind, I would be very happy to hear the results with your screenshot.
edit: No longer available.
When I get home I'll install that jar into my pack and test it! I am happy to help. c:
What I originally said was to say that I think this PR would fix my issue because the symptoms looked exactly the same as what I was experiencing.
The splashes work now, but waterfall particles now crash the game:
The splashes work now, but waterfall particles now crash the game
Many thanks! I cannot thank you enough <3
I know that WaterfallCloudGenerators.tickParticles()
crashes in this build, it will be fixed by #83. Also SplashParticle#tick()
may cause a crash if there are too many underwater entities, it will be fixed by #87.
You can get the built jar with all the changes taken from here if you want. This build also includes #102.
~Effective 1.2.1: lonefelidae16:Effective/patcher-1.18~
~Effective 1.2.2: lonefelidae16:Effective/patcher-1.19~
edit: No longer available.
RenderLayer.getEntityTranslucent(Identifier)
instead of custom classNoShadingRenderLayer
Tested on Intel HD Graphics 520 [Core profile 4.6] MESA 22.0.1
See #6, #7, #12, #18, #50, #63, #67
~The built jar can be found from here: lonefelidae16:fix/black-splashes~ edit: No longer available.