Ladysnake / Impaled

Trident update mod.
13 stars 18 forks source link

compatibility with soul fire´d #44

Open slovinsqui opened 1 year ago

slovinsqui commented 1 year ago

I just noticed the soulfork sets enemies on normal fire instead of blue fire there´s a mod called soul fire´d that has an API for compatibility for that, it would be cool if you could add compatibility with it

https://www.curseforge.com/minecraft/mc-mods/soul-fired

Eman-3600 commented 1 year ago

If they were to add that, they'd more likely do it for https://www.curseforge.com/minecraft/mc-mods/on-soul-fire instead.

Crystal-Spider commented 1 year ago

However my mod makes it way easier to add compatibility for ;) Also my mod adds enchantments and the possibility to have a whole ecosystem of fires registered by other mods, possibly allowing in the future to have different tridents that set on different kind of fire. Furthermore it has a more consistent fire behavior.
Of course I know that 5M downloads vs 30k is a big difference. However consider the ease of use, that maybe by adding Soul Fire'd as an optional dependency it will help get more widespread and the potential long term investment, I'd at least consider it!

P.S. I take this comment to mention this issue to track its progresses.

Eman-3600 commented 1 year ago

Yeah perhaps. Honestly, a better thing to ask for is the ability to import it into a project to make addons.

ImWhiff commented 1 year ago

Me three begs the Soul fork to be compatible with Soul Fire'd 👉👈