Ladysnake / Requiem

Revamps Minecraft's vanilla death experience and adds various related mechanics.
https://ladysnake.github.io/wiki/requiem
Other
120 stars 59 forks source link

Extremely weird mixin error that appears when using your mod #580

Open Sunconure11 opened 2 years ago

Sunconure11 commented 2 years ago

https://pastebin.com/fGwb5Fzz

Pyrofab commented 2 years ago

This looks like another mod has a conflicting @Overwrite or @Redirect on the same method. Do you have an idea as to which mod is conflicting ?

Sunconure11 commented 2 years ago

I’m not entirely sure.

EmmyPynk commented 2 years ago

Try removing Better Combat. I had this same issue so I took a look at your pastebin and noticed we both were using Better Combat. I removed Better Combat, now it loads perfectly.

Sunconure11 commented 2 years ago

I'll have to do it later, I am busy with porting a mod to Quilt.

Sunconure11 commented 2 years ago

@EmmyPynk This issue I'm having with porting a Quilt mod will probably take a few days to resolve. I suggest you talk with Pyro more in this issue.

Sunconure11 commented 2 years ago

I can get to this shortly. I've managed to get said mod on Quilt now.

Sunconure11 commented 2 years ago

Not Simply Swords in my case. It is blaming Supplementaries. Will try without it.

https://pastebin.com/jeU37Eph

Sunconure11 commented 2 years ago

Not supplementaries. I did get a crash report this time as well, but I don't know how much help it would be.

https://pastebin.com/U7pKLWDC

Pyrofab commented 2 years ago

Oh, maybe this is related to loading order. Does it come and go as you change the mod list ?

Sunconure11 commented 2 years ago

It would seem this is probably the case

Pyrofab commented 2 years ago

Could you try again with beta 15 ? Shouldn't depend on load order now.

Sunconure11 commented 2 years ago

https://gist.github.com/Sunconure11/beb999dfc5210623c0cd279d3c6fe65d

Pyrofab commented 2 years ago

Damn o_O

Does this happen with specific mods ?

Sunconure11 commented 2 years ago

I think a mod is triggering it, yes, but I have no clue what.

Sunconure11 commented 2 years ago
[18:40:51] [main/ERROR]: Mixin apply for mod requiem failed mixins.requiem.common.json:data.ItemPredicateMixin from mod requiem -> net.minecraft.class_2073: org.spongepowered.asm.mixin.transformer.throwables.InvalidMixinException Unexpecteded NullPointerException whilst transforming the mixin class: [INJECT Applicator Phase -> mixins.requiem.common.json:data.ItemPredicateMixin from mod requiem -> Apply Injections -> PreInject -> mixins.requiem.common.json:data.ItemPredicateMixin from mod requiem->@Inject::fromJson(Lcom/google/gson/JsonElement;Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfoReturnable;Lcom/google/gson/JsonObject;)V]
org.spongepowered.asm.mixin.transformer.throwables.InvalidMixinException: Unexpecteded NullPointerException whilst transforming the mixin class: [INJECT Applicator Phase -> mixins.requiem.common.json:data.ItemPredicateMixin from mod requiem -> Apply Injections -> PreInject -> mixins.requiem.common.json:data.ItemPredicateMixin from mod requiem->@Inject::fromJson(Lcom/google/gson/JsonElement;Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfoReturnable;Lcom/google/gson/JsonObject;)V]

This looks to be of interest @Pyrofab

Pyrofab commented 2 years ago

Yeah, I figured it was of interest in some way, but it clearly does not happen with only requiem so it would be super helpful if I could know which circumstances are triggering it

Sunconure11 commented 2 years ago

Hm, is there anything you can do without knowing what triggers it? I've been trying to debug stuff like this with other mods and have been unable to find what triggers such errors.

Sunconure11 commented 2 years ago

Looking at the error some more, could you look into the ItemPredicateMixin and it’s relation to mods like Better Nether and other mods by the same devs?

Sunconure11 commented 2 years ago

I have a good chance of losing power and/or internet due to the hurricane

Sunconure11 commented 2 years ago

@Pyrofab check discord

EightBlade commented 1 year ago

I'm having a more or less identical issue.

Redfan2 commented 1 year ago

Is this Issue still active? Otherwise it would be nice if you could close it. Thanks for taking the time to report it

Sunconure11 commented 1 year ago

Haven't used Requiem, or rather, tried to, in a while, so I cannot say.

Sunconure11 commented 1 year ago

@Redfan2 I think I know what causes the issue. Try looking into the following mods: Simply Swords, Knaves Needs, Better Combat, and anything that relies on them.

Edit: YEP IT IS THEM

Sunconure11 commented 1 year ago

https://pastebin.com/iLeCaNK3