Laeoying / pinterestdarktheme

Apply dark theme to Pinterest web.
https://chromewebstore.google.com/detail/pinterest-dark-theme/lkmnhgalhcdimcbhngcmhfcjpmdphkdh?hl=en-GB&authuser=1
1 stars 1 forks source link

Problems with search and themes when refreshing #3

Open NullDott opened 3 months ago

NullDott commented 3 months ago

Search

There's a rendering issue in the search bar on Pinterest when the extension is enabled, causing it to be transparent, seems to happen when the below issue occurs too, or the white theme is active: image

Themes

There's also a problem when refreshing Pinterest where the applied theme will reset to white, even when the "Always allow in domain" option is active, this makes the extension practically unusable since you have to apply the theme over and over again when refreshing the [page.]

https://github.com/Laeoying/pinterestdarktheme/assets/101472580/4117dfc2-a101-4e23-8409-e40ab9339063

Firefox 126

Laeoying commented 3 months ago

Yup I saw that when I've posted it on Mozilla. I'll try to fix it when I'll have time, don't have much right now :/ Thanks for reporting tho :)

Laeoying commented 3 months ago

Btw the transparent layer append when there's no enabled theme I believe, eg when you load the page and didn't select any theme. Actually, the extension is using Chrome storage, that's why it doesn't work I think.

NullDott commented 3 months ago

Thanks so much!

NullDott commented 3 months ago

The issue seems to keep happening after the last update, is it related to the manifest.json mentioned?

Filipermaster commented 3 months ago

After some proper research, I found out the issue was due to minor differences between Chrome's and Mozilla's storage APIs, making the lazy fix useless. Those cases, and some others, were hopefully accounted for, so expect the next update to at least render the plugin usable. The only compromise might be the color fade effect not work on Firefox.

Laeoying commented 3 months ago

I nearly finished my exams so I'll work on it soon :)

NullDott commented 3 months ago

It's okay! Take your time 😊