search

Laerdal / Xamarin.AzureCommunicationCalling

Xamarin iOS and Android binding libraries for Microsofts Azure Communication Services
MIT License
35 stars 11 forks source link

Screensharing is available for android! #29

Closed andersonvieiragomeslopes closed 2 years ago

andersonvieiragomeslopes commented 2 years ago

Hi again, and thanks for the package and the support service provided, it has been working well.

Screensharing was recently added to the project, could you update the android package so we can test the feature?

https://github.com/Azure/Communication/blob/master/releasenotes/acs-calling-android-sdk-release-notes.md Version: v2.3.0-beta.1 (2022-06-07)

Thanks!

Best Regards Anderson Lopes

tompi commented 2 years ago

@andersonvieiragomeslopes i just released binding for 2.3.0-beta.1

The catch is any competeableFuture methods will be dropped... Just let me know which ones you are missing and I will add them to the helper

andersonvieiragomeslopes commented 2 years ago

The catch is any competeableFuture methods will be dropped...

Yes, that's correct, I understood the helper's motive when I looked deeper into the sdk, his work was the best so far.

Do you accept contributions (Xamarin.Forms) to improve the sample (new app TestApp2 android/ios/uwp) app's designer and functionality? Match it to the official azure app, include all official features, show participants, configure audio output, integration with teams and others, android, ios and uwp.

image image image image

tompi commented 2 years ago

Of course, that would be great! Send a pull request

On Sat, 18 Jun 2022 at 18:22, Anderson Lopes @.***> wrote:

The catch is any competeableFuture methods will be dropped... Yes, that's correct, I understood the helper's motive when I looked deeper into the sdk, his work was the best so far.

Do you accept contributions (Xamarin.Forms) to improve the sample (new app TestApp2 android/ios/uwp) app's designer and functionality? Match it to the official azure app, include all official features, show participants, configure audio output, integration with teams and others, android, ios and uwp.

[image: image] https://user-images.githubusercontent.com/26186056/174447428-602c0196-f86b-4ee1-8ab7-51f4a8659030.png [image: image] https://user-images.githubusercontent.com/26186056/174447434-7ece8ae3-5961-40da-b73a-788fe341dbce.png [image: image] https://user-images.githubusercontent.com/26186056/174447440-3ef89b80-93ce-4bbe-ac7c-1e1d5809ad04.png [image: image] https://user-images.githubusercontent.com/26186056/174447442-30348942-75d5-4001-b3c8-e64c96033921.png

— Reply to this email directly, view it on GitHub https://github.com/Laerdal/Xamarin.AzureCommunicationCalling/issues/29#issuecomment-1159501398, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABYSJLBA4DYFW42IYWY7HLVPXZTNANCNFSM5YQMDY6A . You are receiving this because you commented.Message ID: <Laerdal/Xamarin. @.***>

-- @.***, 90786985

tompi commented 2 years ago

@andersonvieiragomeslopes can I close this issue? It was originally about upgrading libs, which I think is ok now?

andersonvieiragomeslopes commented 2 years ago

@tompi Yes, tweaks to the helper are not necessary, thanks, add the feature as well to the new example that is under construction.

andersonvieiragomeslopes commented 2 years ago

@tompi the example with more features is under construction, I believe it makes sense to keep this open until the feature is added there. What do you think? I'm finalizing the last details to submit the PR, but the readme is already available. https://github.com/andersonvieiragomeslopes/Xamarin.AzureCommunicationCalling

tompi commented 2 years ago

merged the pr, thank you for the wonderful examples @andersonvieiragomeslopes