search

Laerdal / Xamarin.AzureCommunicationCalling

Xamarin iOS and Android binding libraries for Microsofts Azure Communication Services
MIT License
36 stars 11 forks source link

Properly build package for net7-ios #49

Closed kmiterror closed 9 months ago

kmiterror commented 9 months ago

This PR does few things to bring the AzureCommunicationCalling native lib to work with net7-ios In the process I have modified create_binding.sh so it's self contained. You can run script multiple times and it will copy files accordingly and modify the .h files to adjust references to AzureCommunicationCommon. Effectively create_binding.sh should create ApiDefinitions.cs and StructsAndEnums.cs every time regardless of what version of the native lib you will use. The process of preparing a package looks now like:

  1. run create_binding.sh
  2. do the manual adjustments in ApiDefinitions.cs and StructsAndEnums.cs files
  3. dotnet build

The nuget package works on M1 cpu, for both ios simulator and real device. It has not been tested on x86 machine. There is no CallDelegate crash anymore Some more issues are fixed due to latest AzureCommunicationCalling being used.

tompi commented 9 months ago

Hey, this is super work! Maybe just get "beta" in the version number, and address the net7/8 thing, and I will merge it