search

Laerdal / Xamarin.AzureCommunicationCalling

Xamarin iOS and Android binding libraries for Microsofts Azure Communication Services
MIT License
35 stars 11 forks source link

iOS Consume & Update ACS from Cocoapods #8

Closed mariusu-msft closed 3 years ago

mariusu-msft commented 3 years ago

https://github.com/mariusu-msft/Xamarin.AzureCommunicationCalling/tree/use-cocoapods

I've added support to use ACS from Cocoapods here. It may be desirable to checking in the libs directly, since it allows for easy update to latest.

Let me know if I should create a pull request.

tompi commented 3 years ago

Nice, thank you @mariusu-msft ! Would appreciate a pull request! Ill try to get it merged as soon as possible.

P.S. I saw you referenced ios 13 in the Podfile, the minimum sdk version should be 12.0 shouldnt it?

tompi commented 3 years ago

@mariusu-msft Just tried installing from cocoa pods and it works very well! A minor detail is that Info.plist of AzureCommunicationCalling has some strange values: minimumosversion=10, should be 12, right? Also, BunleVersionShort is "1.0.0-beta.4" which doesnt fly with iTunes Connect: https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundleshortversionstring

mariusu-msft commented 3 years ago

Closing this. Will send a new PR to update to 1.0.0-beta.5 fix the minOSVer

raosanat commented 3 years ago

@mariusu-msft @tompi i made a last minute fix for this issue, so 1.0.0-beta.5 already has the proper short version in info.plist

tompi commented 3 years ago

Hey. No need. I already figured out the correct git shas for beta 5 for the other libs. Should be updated now

On Thu, 19 Nov 2020 at 18:56, Marius U notifications@github.com wrote:

Closing this. Will send a new PR to update to 1.0.0-beta.5 fix the minOSVer

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/Laerdal/Xamarin.AzureCommunicationCalling/issues/8#issuecomment-730540014, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABYSJKOIKRKB6HA6ULQR3LSQVL47ANCNFSM4TX6H4SA .

-- Thomas.Haukland@gmail.com, 90786985

mariusu-msft commented 3 years ago

We are going to be publishing to Trunk CocoaPods in next couple of days. I’ll send a PR for that when it will be available.

Get Outlook for iOShttps://aka.ms/o0ukef

From: Thomas Haukland notifications@github.com Sent: Thursday, November 19, 2020 10:15:42 AM To: Laerdal/Xamarin.AzureCommunicationCalling Xamarin.AzureCommunicationCalling@noreply.github.com Cc: Marius Ungureanu mariusu@microsoft.com; Mention mention@noreply.github.com Subject: Re: [Laerdal/Xamarin.AzureCommunicationCalling] iOS Consume & Update ACS from Cocoapods (#8)

Hey. No need. I already figured out the correct git shas for beta 5 for the other libs. Should be updated now

On Thu, 19 Nov 2020 at 18:56, Marius U notifications@github.com wrote:

Closing this. Will send a new PR to update to 1.0.0-beta.5 fix the minOSVer

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/Laerdal/Xamarin.AzureCommunicationCalling/issues/8#issuecomment-730540014, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABYSJKOIKRKB6HA6ULQR3LSQVL47ANCNFSM4TX6H4SA .

-- Thomas.Haukland@gmail.com, 90786985

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FLaerdal%2FXamarin.AzureCommunicationCalling%2Fissues%2F8%23issuecomment-730550191&data=04%7C01%7Cmariusu%40microsoft.com%7Cc693d8bc47204bde9fe208d88cb720f2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637414065482670848%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=MN2E59UE144idf4p86L2mtczbOl6myjqxOWG6UCiPtM%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAOATQRD45CQWCXSHZU5AG3LSQVOE5ANCNFSM4TX6H4SA&data=04%7C01%7Cmariusu%40microsoft.com%7Cc693d8bc47204bde9fe208d88cb720f2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637414065482680839%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=CGQvKxmrnEuMuGKQKX2j2zjvrhs3RpFxgBeynhAL5KI%3D&reserved=0.