search

Laerinok / VS_ModsUpdater

Easily update your favorite mods
MIT License
2 stars 3 forks source link

Error executing the file.exe #25

Closed Sir-Ryu closed 7 months ago

Sir-Ryu commented 8 months ago

Hello, When starting the program, it opens, displays the title, and then closes instantly. After several attempts, I managed to get it to show the error. Error ModUpdate

Laerinok commented 8 months ago

Hello, Thanks. It should be fixed with the v1.3.1

Laerinok commented 8 months ago

Well. There were still some crashes. Hope it's fixed with 1.3.2

Sir-Ryu commented 7 months ago

Hi, update from today: I've been testing the app, and it still breaks. Captura de pantalla 2024-02-27 055647

Laerinok commented 7 months ago

hem... Always the modinfo that messes. I changed the way I get its content to avoid writing a temp file but it seems I messed more than I thought. The problem is not a big deal. I know what it is : Althought the modinfo.json file is supposed to be written in a standard format, it's not the case, depending of modders. Generally it is a coma at the wrong place. Either I forgot a special case or there is a new format.

If you could tell me what mods you have I will investigate quickly because I cannot reproduce this crash.

sorry for the inconvenience.

PS: I should try to find how to give more info when crashes... But for now I don't know how I can do it. I should search deeper

Laerinok commented 7 months ago

I've made a quick new version which should generate a log file to help to identify the issue. A log folder with a crash-log.txt file should be created

You can DL it here : https://github.com/Laerinok/VS_ModsUpdater/releases/download/Test_Version/VS_ModsUpdater.v.1.3.3-rc1.zip

Sir-Ryu commented 7 months ago

Don't worry, it's a pleasure to help as a tester. Regarding the error, you're right. The issue was caused by the mod "Hey! Bales! A hay bale mod" with its modinfo.json format. Apart from that, everything works well after updating and creating the PDF file. Good job! VS_Mods_2024_02_27.pdf crash-log-20240227220412.txt

Laerinok commented 7 months ago

OK. That's a good thing. I will be to able now to fix it. I hope this will the last, but at least it will be easier to fix futur issues.

PS : I saw you used english text. Is it a choice, or you didn't config it for tests or the right language is not displayed ?

Sir-Ryu commented 7 months ago

Hello, how are you? I've tried the new version 1.3.3 and I've found some issues:

Everything else is still working fine. End of report.

update completed_20240301_075926.txt

update error_20240301_080635.txt

Error Detection Last Version

Laerinok commented 7 months ago

Hello, I'm fine thanks.

Very strange for the language. I tried and any file lang I loaded worked as intented. Did you use the new file ? I mean I added some new string with last update. Did you set it in config or system detects it ?

For the issue of mods no updated when you set a limit, it's fixed in the v1.3.4. I was going to pur it onlive yesterday when someone reported some new issue, so I am waiting. But you can try it. https://github.com/Laerinok/VS_ModsUpdater/releases/download/v1.3.4/VS_ModsUpdater.v.1.3.4.zip

For Alloy Calculator, It's very strange. I never met this issue before. I will investigate.

Once again, thanks :)

Laerinok commented 7 months ago

OK, Well... For alloy Calculator I'am affraid I cannot do anything. It is an 'issue' with the moddb. If you look at the date, the v1.0.0 is older than the v0.0.1 and it's the same with the API. But I guess that when the mod will have a new update it will have the right date and it would be OK.

VS_Screenshot_2

api

Sir-Ryu commented 7 months ago

Sorry. The language configuration was my mistake. I forgot that it's commented with # since I don't use Python, which led me to think, to make the configuration clearer to the average user, change line 8 of the config.ini to:

"To change the default language, uncomment the line below by removing the # symbol and set the desired language ('lang' folder)."

Or directly add for a future version the ability to configure it from the terminal itself when first used, something like:

Welcome to Mods Updater v.1.3.x!

Please select your language:

  1. Deutsch
  2. English
  3. Español
  4. Français
  5. Italiano
  6. Português
  7. Русский
  8. Українська

Enter the number corresponding to your language choice:

"Just in case, here it requires that only numbers can be entered to avoid errors."

Would you like to configure the game version? [yes/no]

Please enter the game version you'd like to use:

First execution of the program, creation of the config.ini file done. You can continue with the update or add the mods to exclude in the config.ini file.

Continue updating? [yes/no/y/n]:

Laerinok commented 7 months ago

That's what I thought :) But there something weird. The script should detect your system language and use it if it's in the lang folder. That's a quite good idea to configure the lang at the start. I will think about it. That is the "problem", when I started to make this script it was for my personal use. And when I decided to share it I didn't think it was so downloaded and many suggestions came more and more:) Great thing, but I a am still learning. It's my first program ! :)

I've updated the description page this afternoon. I hope it makes more sense.

Sir-Ryu commented 7 months ago

Ummm, I ran several tests, and it seems that the language detection script isn't working. By the way, I'm not sure if your script works like this or not, but it should detect the administrative language setting, "since it tends to be the most stable configuration, so to speak, as it requires a full PC restart to apply, unlike the Windows language that can be changed from the taskbar or notifications with a simple click. And on the other hand, wouldn't the code be quite long? I say this because of the number of variations of each country of the same language, such as Spanish, which has about 22 variations, unless you can make it detect only the first part, for example, instead of detecting or identifying "English (United Kingdom)" only identify "English", or that it can identify keywords that you configure like "English". But well, don't take this too much into account, since I don't know how Python's information processing works. On the other hand, I did some testing with code AI for that function I mentioned, so check if it can work or not.

v1.txt

v2.txt

Sir-Ryu commented 7 months ago

You did a great job for your first program. Keep it up, it's a good project to include in your portfolio.

Laerinok commented 7 months ago

Thanks :) Now that I've fixed all reported issues and cleaned a bit the code I will have a look for the language. I like the idea of have a choice at the start and it is probably best than trying to let the system detects. Because there are many ways to get language and I remember having many discussions about it and nobody wanted the same thing. Moreover I use the same script for Windows and Linux and I had a lot of duty to understand the different way to get the same info.

I am not sure to have understood what you told about the 22 variations for spanish. I mean, it does not matter how many variations there are, if I have the lang file it's very easy to load it according the choice of the user.

But anyway, you gave me a good idea as an exercice. It will be the next "major" update. Well, in practice I am not sure that having a language other than english is very important, but it is good for the Quality Of Life ^^