search

LafColITS / moodle-local_ldap

Various synchronization scripts between Moodle and LDAP directories (see https://tracker.moodle.org/browse/MDL-25011 )
9 stars 7 forks source link

Update locallib.php #40

Closed AdamosD7 closed 7 months ago

AdamosD7 commented 7 months ago

This change should fix the issue with empty nasted groups. https://github.com/LafColITS/moodle-local_ldap/issues/29

mackensen commented 7 months ago

@AdamosD7 thanks; this change seems sane though per the discussion there's no automated test coverage. The same change should probably be made as well on line 276 for OpenLDAP. I've just pushed a major refactoring of the test coverage; can you please rebase off current main and update your commit message to reference issue #29 explicitly? Thanks again.

AdamosD7 commented 7 months ago

I´m happy that my fix helped you but I don´t understand what to do... I´m new in GitHub sorry 😄

mackensen commented 7 months ago

@AdamosD7 that's all right, I've taken care of it. The next release (v4.1.0) will incorporate your fix. Please let me know if you're able to test in your environment and verify that it's working. Thanks again for your contribution!

AdamosD7 commented 6 months ago

@mackensen I will check the functionality of the new version next week, I will let you know.