search

LafColITS / moodle-report_roster

A simple Moodle report which displays the user pictures for everyone enrolled in a given course.
1 stars 7 forks source link

Large class lists are not printing properly #14

Open adamann2 opened 5 years ago

adamann2 commented 5 years ago

With Moodle 3.5 and the Boost theme, large class lists do not print correctly. The list gets truncated after one page. A workaround is to add the following to the theme's SCCS -

@media print { .card { display: block; } }

mackensen commented 5 years ago

Hi @adamann2, thanks for the report. Unfortunately, I'm unable to reproduce this problem in any of my test environments. Using both the "web" and "printable" display modes I can print a roster that includes ~150 users and spans multiple pages. The roster plugin doesn't use the card css class at all.

adamann2 commented 5 years ago

Sorry - I should have included a few more details.

We are running Moodle 3.5.3+. I'm testing with a course that has 101 users, using Firefox 64.0. If I select "printable" display, then use the browser's print function, I get a page with the first 80 students, followed by a blank page. Printing the "web" display page is a bit worse - I get a blank page, a page with 80 users (with the last row cut off mid-image), then another blank page.

Roster.pdf

The page has a flex div (class=card), and there seems to be an issue with printing multi-page flex containers in Firefox.

screenshot from 2019-01-22 16-44-10

mackensen commented 5 years ago

Thanks @adamann2, I can reproduce this in Firefox now. I'm curious if there are also places in core Moodle which exhibit this behavior, but I'll also work on shipping a plugin-specific fix.

mackensen commented 5 years ago

Link to core Firefox issue: https://bugzilla.mozilla.org/show_bug.cgi?id=939897.

andyzito commented 4 years ago

Hey @adamann2 , is this still happening for you in the latest version of Firefox? I attempted to reproduce and it seems like things might be fixed.