search

LagPixelLOL / cog-sdxl

Inference SDXL with cog including multiple models in 1 instance support.
MIT License
5 stars 4 forks source link

New defaults & shit like that #5

Closed Succubyss closed 3 weeks ago

Succubyss commented 3 weeks ago

A whole bunch of new default constants. Renamed POSITIVE_PREPROMPT to DEFAULT_POS_PREPROMPT and similar for the negative. Then I moved stuff around in constants.py until their order made a bit more sense without breaking things.

Moved DEFAULT_VAE_NAME = BAKEDIN_VAE_LABEL if DEFAULT_VAE_NAME is None else DEFAULT_VAE_NAME to the top of predict.py, added an assert for the clip skip, and the list of scheduler names is now done from within constants.py.

I made sure that the cog compiled (whatever the hell it does) and it spat out an image just fine.

Succubyss commented 3 weeks ago

@LagPixelLOL I see you reverted the change to the default prompts, but I have to ask you at least make the default negative prompt blank. On Discord bot related deployments, it makes it so that if a user doesn't manually specify a negative prompt, it assumes the prompt you set.

It's also why I made the default positive prompt "safe" so that if an image generation trigger is performed without any parameters it simply generates a safe image. However, I can live with it being 1girl, I just really think it make smore sense for the default negative prompt to be empty.

LagPixelLOL commented 2 weeks ago

You can specify something like an empty string when submitting to the API then it won't use the default prompt. I set it that way so it's easier to use for a specific model (tPonynai3), it's the reason why most of the default settings are in the current way too.