search

LagoLunatic / DSVEdit

Multi-purpose editor for ROM hacking DS and GBA Castlevania games
MIT License
91 stars 12 forks source link

Importing the manticore boss room of aria of sorrow from tiled causes a visual glitch #82

Closed fcard closed 6 months ago

fcard commented 6 months ago

Tested from the latest source. Can be reproduced by simply importing from tiled with no changes. It also already looks like this in the editor itself Room ID is 06 08511DCC, in the chapel. built_rom_aos-0

LagoLunatic commented 6 months ago

The bug was that DSVEdit recalculates the width in pixels and height in pixels of each layer based on the number of screens wide/tall it is, but that seems to be incorrect specifically for AoS layers that have scroll mode C or D, so now I've changed it to skip doing this in those cases.

If you ever need to change the number of screens wide/tall a layer that has scroll modes C or D in AoS is, you may have to manually adjust the pixel widths/heights by opening it in Tiled and editing the new Tiled-only fields layer_width_in_pixels and layer_height_in_pixels.