LagoLunatic / wwrando

Wind Waker Randomizer
https://lagolunatic.github.io/wwrando/
MIT License
383 stars 85 forks source link

asm: Support disassemble on non-windows #371

Closed Aelire closed 7 months ago

Aelire commented 7 months ago

Check for devkitppc using the environment variable on non-windows so --disassemble also works on unix platforms, in a similar fashion to how it is done in https://github.com/LagoLunatic/wwrando/blob/1efcfd2b93dcb3ce860b2d625cbb7d308c0853ea/asm/assemble.py#L12-L16, Unlike in asm/assemble, this file loaded on every invocation of the randomizer even without --disassemble so the check for devkitppc is only done when needed instead of when the file is loaded

Another option could be to factor this check into a common file that both assemble.py and disassemble.py import; I can update the PR and resend with that if that's a better option