search

LagoLunatic / wwrando

Wind Waker Randomizer
https://lagolunatic.github.io/wwrando/
MIT License
383 stars 85 forks source link

Fix nonrandomized dungeon entrances with randomized boss entrances and required bosses mode #390

Closed Aelire closed 4 months ago

Aelire commented 4 months ago

Currently, the combination of randomizing boss entrances but not dungeon entrances when using required bosses mode mostly fails to randomize successfully. Example permalink: MS4xMC4wXzM5NTRjZTkAQQAFEEAUAAH7AugSAAAgAIAAhCAAQAA=. A bulk test with these settings seems to have a 100% failure rate, but other values for number of required bosses (except 6) also fail to randomize most of the time

The first commit resolves the spurious Not enough island entrances left to split entrances in this case The second commit resolves an underlying bug now made reachable where nonrandomized dungeons weren't tracked in islands_with_a_banned_dungeon, occasionally tripping the not banned_island_names & required_island_names assertion (same permalink, about 10% failure rate)

wooferzfg commented 4 months ago

Probably worth adding the settings you mentioned to the tests?

Aelire commented 4 months ago

Removed an unrelated change from the first commit. It addressed a randomization failure when randomizing dungeon entrances but not boss entrances, ie the opposite situation, where a required dungeon and banned dungeon could still end up on the same island with 2 entrances, but I initially forgot these 2 issues were different. I'll send a separate PR for that second issue

LagoLunatic commented 4 months ago

This also seems to fix the same bug that happens when randomizing inner secret cave entrances but not outer secret cave entrances. Thanks!