search

LaidBackSloth / OculusParticleFix

Fixes a visual glitch with the Oculus shader mod where particles are blinking through walls while picking up items
https://curseforge.com/minecraft/mc-mods/oculus-particle-fix
MIT License
0 stars 0 forks source link

[Suggestion] PR merge with oculus #1

Open OracleHisty opened 8 months ago

OracleHisty commented 8 months ago

Since this "fixes?" a critical bug in the particle library, perhaps contact the original developer to see if you can merge your fix in?

LaidBackSloth commented 6 months ago

After I came up with the fix, I notified Asek3 about it on his Discord, but he tried to come up with his own fix instead of using mine. According to a few other users, his fix still causes some issues that are fixed with mine, but I'm not completely certain about this. He also didn't implement the fix in the 1.18.2 version at all, so I don't think he supports that version anymore. What kept me from actually creating a PR to the Oculus repo is that when I created the fix, the repo was very outdated and the code on there didn't even compile for me. However, now the situation looks better and I'll try to create a PR

EDIT: I just looked at the source code of Oculus, and it seems like recently someone merged a similar fix into Oculus here. I've already done a bit of testing and I think Oculus Particle Fix is not needed in the new 1.20.1 version of Oculus. If it works consistently (which I believe), there should be no need for a pr with my fix, as there is already one. In this case, I'll update the mod description so that it's clear that the mod is not needed anymore with the newest 1.20.1 version of Oculus

OracleHisty commented 6 months ago

Got it!