LaihoE / demoparser

Counter-Strike 2 replay parser for Python and JavaScript
MIT License
291 stars 30 forks source link

Need add dependency of "protobuf-codegen" in csgoproto. #124

Closed jaredliu2018 closed 7 months ago

jaredliu2018 commented 8 months ago

I'm using it in rust directly and the csgoproto project can't compile. I think "protobuf-codegen" should be added to Cargo.toml.

LaihoE commented 8 months ago

What is the error you are getting? I think protobuf-codegen should only be for generating these files, using them should not require it? (I could be wrong).

jaredliu2018 commented 8 months ago

I put demoparse into my project as a submodule. When I build csgoproto I got error below: error[E0433]: failed to resolve: use of undeclared crate or module protobuf_codegen --> demoparser\src\csgoproto\src\main.rs:2:5 | 2 | protobuf_codegen::Codegen::new() | ^^^^^^^^^^^^^^^^ use of undeclared crate or module protobuf_codegen

LaihoE commented 8 months ago

Maybe you are right, won't hurt to add it. Do you want to make a PR or want me to do it?

jaredliu2018 commented 7 months ago

I notice you've add it already. so I'll close this issue. Thanks!